Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-26142: JDK17 support for Ambari-metrics #134

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

sandeep318kumar
Copy link
Contributor

[AMBARI-26142] JDK17 support for Ambari-metrics

What changes were proposed in this pull request?

upgrade maven-compiler-plugin to 3.5
maven-shade-plugin to 3.5.1
guava to 32.1.3-jre
maven-surefire-plugin to 3.2.5
JDK to 17
API changes
tests cases modified

(Please fill in changes proposed in this fix)

How was this patch tested?

TESTING is pending.

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@JiaLiangC
Copy link
Contributor

@sandeep318kumar
Due to being quite busy, we will handle the Ambari metrics-related PRs after completing the JDK, Spring, and other dependency upgrades on the Ambari side. Thank you for your contribution.

@JiaLiangC
Copy link
Contributor

@sandeep318kumar It looks like three tests have failed. Could you please fix them?

@JiaLiangC
Copy link
Contributor

@sandeep318kumar It will be merged first, and the failed unit tests will be submitted in a separate PR.

Copy link
Contributor

@JiaLiangC JiaLiangC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiaLiangC JiaLiangC merged commit 667fa9a into apache:master Nov 29, 2024
1 check failed
@JiaLiangC JiaLiangC changed the title [AMBARI-26142] JDK17 support for Ambari-metrics AMBARI-26142: JDK17 support for Ambari-metrics Nov 29, 2024
@sandeep318kumar
Copy link
Contributor Author

@JiaLiangC Can I work on these test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants